Apply review comments

mtsokol · mtsokol · commit 058ea0ff6a61 · 2024-11-12T12:37:10.000Z
diff --git a/numpy/_core/src/umath/ufunc_object.c b/numpy/_core/src/umath/ufunc_object.c
@@ -5178,6 +5178,7 @@ ufunc_dealloc(PyUFuncObject *ufunc)
         Py_DECREF(ufunc->identity_value);
     }
     Py_XDECREF(ufunc->obj);
+    Py_XDECREF(ufunc->dict);
     Py_XDECREF(ufunc->_loops);
     if (ufunc->_dispatch_cache != NULL) {
         PyArrayIdentityHash_Dealloc(ufunc->_dispatch_cache);
@@ -5198,6 +5199,7 @@ ufunc_traverse(PyUFuncObject *self, visitproc visit, void *arg)
     if (self->identity == PyUFunc_IdentityValue) {
         Py_VISIT(self->identity_value);
     }
+    Py_VISIT(self->dict);
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5178,6 +5178,7 @@ ufunc_dealloc(PyUFuncObject *ufunc)`
`5178`	`5178`	`Py_DECREF(ufunc->identity_value);`
`5179`	`5179`	`}`
`5180`	`5180`	`Py_XDECREF(ufunc->obj);`
	`5181`	`+ Py_XDECREF(ufunc->dict);`
`5181`	`5182`	`Py_XDECREF(ufunc->_loops);`
`5182`	`5183`	`if (ufunc->_dispatch_cache != NULL) {`
`5183`	`5184`	`PyArrayIdentityHash_Dealloc(ufunc->_dispatch_cache);`
`@@ -5198,6 +5199,7 @@ ufunc_traverse(PyUFuncObject self, visitproc visit, void arg)`
`5198`	`5199`	`if (self->identity == PyUFunc_IdentityValue) {`
`5199`	`5200`	`Py_VISIT(self->identity_value);`
`5200`	`5201`	`}`
	`5202`	`+ Py_VISIT(self->dict);`
`5201`	`5203`	`return 0;`
`5202`	`5204`	`}`
`5203`	`5205`