Merge pull request #28055 from charris/backport-28053

charris · web-flow · commit 1113ec1d8528 · 2024-12-22T12:13:33.000-07:00
TYP: fix ``void`` arrays not accepting ``str`` keys in ``__setitem__``
diff --git a/numpy/__init__.pyi b/numpy/__init__.pyi
@@ -2133,6 +2133,8 @@ class ndarray(_ArrayOrScalarCommon, Generic[_ShapeT_co, _DType_co]):
         value: _ConvertibleToDT64 | _NestedSequence[_ConvertibleToDT64],
         /,
     ) -> None: ...
+    @overload  # void
+    def __setitem__(self: NDArray[void], key: str | list[str], value: object, /) -> None: ...
     @overload  # catch-all
     def __setitem__(self, key: _ToIndices, value: ArrayLike, /) -> None: ...
 
diff --git a/numpy/typing/tests/data/pass/ndarray_misc.py b/numpy/typing/tests/data/pass/ndarray_misc.py
@@ -174,3 +174,10 @@ class SubClass(npt.NDArray[np.float64]): ...
 complex(np.array(1.0, dtype=np.float64))
 
 operator.index(np.array(1, dtype=np.int64))
+
+# this fails on numpy 2.2.1
+# https://github.com/scipy/scipy/blob/a755ee77ec47a64849abe42c349936475a6c2f24/scipy/io/arff/tests/test_arffread.py#L41-L44
+A_float = np.array([[1, 5], [2, 4], [np.nan, np.nan]])
+A_void: npt.NDArray[np.void] = np.empty(3, [("yop", float), ("yap", float)])
+A_void["yop"] = A_float[:, 0]
+A_void["yap"] = A_float[:, 1]
