Skip to content

ENH: type np.unicode_ as np.str_ #17479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2020
Merged

ENH: type np.unicode_ as np.str_ #17479

merged 2 commits into from
Oct 9, 2020

Conversation

person142
Copy link
Member

The two are aliases; i.e.

>>> np.unicode_ is np.str_
True

so make them aliases on the typing level too.

@person142
ENH: type np.unicode_ as np.str_
58fe5c6 
The two are aliases; i.e.

>>> np.unicode_ is np.str_
True

so make them aliases on the typing level too.
BvB93
BvB93 reviewed Oct 7, 2020
View reviewed changes
BvB93
BvB93 approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@BvB93 BvB93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; CI failure is unrelated (see #17499).

@charris charris closed this Oct 8, 2020
@charris charris reopened this Oct 8, 2020
@charris charris merged commit dee7399 into numpy:master Oct 9, 2020
@charris
Copy link
Member

charris commented Oct 9, 2020

Thanks @person142 .

@BvB93 BvB93 mentioned this pull request Oct 9, 2020
Closed
@charris charris mentioned this pull request Oct 10, 2020
Closed
20 tasks
@BvB93 BvB93 mentioned this pull request Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BvB93 BvB93 BvB93 approved these changes

Assignees
No one assigned
Labels
01 - Enhancement 41 - Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@person142 @charris @BvB93
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy