Skip to content

chore: make it possible to provide detailed config validation errors #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

jamietanna
Copy link
Member

  • chore: make it possible to provide detailed config validation errors
  • refactor: move Configuration methods closer to struct

As part of future changes, we want to introduce the ability to give us
more control over validating the configuration provided by users.

This follows the usage of a `map[string]string` via [0], which can then
allow us to provide much more useful sets of error messages.

[0]: https://grafana.com/blog/2024/02/09/how-i-write-http-services-in-go-after-13-years/
@jamietanna jamietanna requested a review from a team as a code owner July 12, 2024 13:46
@jamietanna jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Jul 12, 2024
@jamietanna jamietanna merged commit f6622e7 into main Jul 12, 2024
26 checks passed
@jamietanna jamietanna deleted the chore/validation branch July 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Any maintenance tasks that are regular, not as important to call out in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy