Skip to content

Revert "fix(template): fix strict-interface template to make sure text response content type uses string type (#1132)" #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2024
Merged

Revert "fix(template): fix strict-interface template to make sure text response content type uses string type (#1132)" #1773

merged 2 commits into from
Sep 20, 2024

Conversation

jamietanna
Copy link
Member

@jamietanna jamietanna commented Sep 20, 2024 •
edited
Loading

This reverts commit df2cf43.

As raised in #1676, this was a breaking change, and means that
text/plain responses cannot interact with their headers.

This additionally adds tests for this case.

Closes #1676.

@jamietanna
chore(tests): add test case for #1676
ee97242 
Adds a test cases for #1676.
@jamietanna
Revert "fix(template): fix strict-interface template to make sure tex…
e476b95 
…t response content type uses string type (#1132)"

This reverts commit df2cf43.

As raised in #1676, this was a breaking change, and means that
`text/plain` responses cannot interact with their headers.

Closes #1676.
@jamietanna jamietanna requested a review from a team as a code owner September 20, 2024 15:41
@jamietanna jamietanna mentioned this pull request Sep 20, 2024
Merged
@jamietanna jamietanna merged commit 891a067 into main Sep 20, 2024
34 checks passed
@jamietanna jamietanna deleted the issue/1676 branch September 20, 2024 15:44
@jamietanna jamietanna added bug Something isn't working notable changes Used for release notes to highlight these more highly labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working notable changes Used for release notes to highlight these more highly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

echo strict server when content-type is Text/plain
1 participant
@jamietanna
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy