Skip to content

docs: simplify go tool example #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Conversation

gaiaz-iusipov
Copy link
Contributor

No description provided.

@gaiaz-iusipov gaiaz-iusipov requested a review from a team as a code owner February 21, 2025 19:43
@jamietanna
Copy link
Member

Hmm, I didn't think that worked - mind updating the example in https://github.com/oapi-codegen/oapi-codegen/tree/main/examples/minimal-server/stdhttp-go-tool to match, too?

@gaiaz-iusipov
Copy link
Contributor Author

Sure, of course

@gaiaz-iusipov
Copy link
Contributor Author

It looks like the linter is failing due to the Go version in the go.mod file. Should I revert the file to its previous version? In that case, the code example might not be entirely correct

@gaiaz-iusipov
Copy link
Contributor Author

Alright, I don't think there's any simple solution other than go mod edit -go=1.22.
I reverted the version back

@jamietanna
Copy link
Member

Thanks! I think that change you reverted is something worthwhile, so I'll get a PR raised for that and merge it prior to this

@jamietanna jamietanna enabled auto-merge (squash) March 14, 2025 22:13
Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@jamietanna jamietanna merged commit 4912cb8 into oapi-codegen:main Mar 14, 2025
24 checks passed
@gaiaz-iusipov gaiaz-iusipov deleted the docs-fix branch April 2, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy