Enable forcing non-pointer types using Nullable #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed update to GoTypeDef to enable forcing a non pointer type. This is useful in go to avoid using `*string` instead of `string` in most cases where the value is not required, but there's no need to differentiate between `nil` and empty string values. See also oapi-codegen#479
|
May we consider adding this as a default behaviour? We have many YAML spec files, and annotating 1000s of properties with Technically, the generator should respect a built-in In other word for the sollowing schema: schema:
type: object
properties:
nonNullable:
type: string
nonNullableExplicit:
type: string
nullable: false
nullable:
type: string
nullable: trueThe expected struct: type JSONBody struct {
nonNullable string `json:"nonNullable,omitempty"`
nonNullableExplicit string `json:"nonNullableExplicit,omitempty"`
nullable *string `json:"nullable,omitempty"`
}Instead it produces pointers everywhere: type JSONBody struct {
nonNullable *string `json:"nonNullable,omitempty"`
nonNullableExplicit *string `json:"nonNullableExplicit,omitempty"`
nullable *string `json:"nullable,omitempty"`
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed update to GoTypeDef to enable forcing a non pointer type. This is useful in go to avoid using
*stringinstead ofstringin most cases where the value is not required, but there's no need to differentiate betweenniland empty string values.There may need to be some more semantics around this in order to force the pointer in some cases where
p.Nullableis true. We probably need some discussion around this prior to merging.See also #479