Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/consensus/tendermint/epochtime_mock: Fix initial notify #3060

Merged
merged 1 commit into from
Jun 29, 2020
Merged

go/consensus/tendermint/epochtime_mock: Fix initial notify #3060

merged 1 commit into from
Jun 29, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 29, 2020

No description provided.

@kostko kostko force-pushed the kostko/fix/tm-epochtime-mock branch from 3f61b02 to fbec6a2 Compare June 29, 2020 12:08
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #3060 into master will increase coverage by 0.03%.
The diff coverage is 55.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3060      +/-   ##
==========================================
+ Coverage   68.45%   68.49%   +0.03%     
==========================================
  Files         372      372              
  Lines       36489    36487       -2     
==========================================
+ Hits        24978    24990      +12     
+ Misses       8306     8296      -10     
+ Partials     3205     3201       -4
Impacted Files Coverage Δ
...sensus/tendermint/epochtime_mock/epochtime_mock.go 70.34% <55.00%> (-2.45%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/query.go 63.63% <0.00%> (-18.19%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 77.58% <0.00%> (-3.45%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 66.29% <0.00%> (-3.38%) ⬇️
go/oasis-node/cmd/keymanager/keymanager.go 48.88% <0.00%> (-1.95%) ⬇️
go/runtime/committee/client.go 78.22% <0.00%> (-1.21%) ⬇️
go/runtime/registry/registry.go 73.49% <0.00%> (-1.21%) ⬇️
go/storage/client/client.go 75.31% <0.00%> (-0.86%) ⬇️
go/runtime/client/client.go 71.53% <0.00%> (-0.73%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822f7b9...fbec6a2. Read the comment docs.

@kostko kostko marked this pull request as ready for review June 29, 2020 12:47
ptrus
ptrus approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this caused the initial epoch to be always 0 if a node was restarted or started late in tests with mock eopchtime right? Noticed this a while ago as well, but forgot to act on it

@kostko
Copy link
Member Author

kostko commented Jun 29, 2020

Exactly! :-)

@kostko kostko merged commit 67bc6ad into master Jun 29, 2020
@kostko kostko deleted the kostko/fix/tm-epochtime-mock branch June 29, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yawning Yawning Yawning approved these changes

@ptrus ptrus ptrus approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostko @Yawning @ptrus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy