(feat) O3-4342: Split allergy form fields #2193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Muppasanipraneeth could you add screenshots to support your changes? |
denniskigen
reviewed
Jan 17, 2025
packages/esm-patient-allergies-app/src/allergies/allergies-detailed-summary.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-allergies-app/src/allergies/allergies-form/allergy-form.workspace.tsx
Outdated
Show resolved
Hide resolved
denniskigen
reviewed
Jan 20, 2025
packages/esm-patient-allergies-app/src/allergies/allergies-form/allergy-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-allergies-app/src/allergies/allergies-form/allergy-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-allergies-app/src/allergies/allergies-form/allergy-form.workspace.tsx
Outdated
Show resolved
Hide resolved
|
@ibacher When you mentioned that the Allergy sub-resource in the REST API supports recording reaction events, what property would we use to record that in the data model? Is it |
It should be the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR separates the 'Onset date' and 'Additional comments' fields in the allergy form. Presently, the two are combined in a single field. Separating them aligns them with the designs and allows for proper validation of the individual fields.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-4342
Other