Skip to content

Fix faulty return type hint. #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix faulty return type hint. #254

wants to merge 2 commits into from

Conversation

martinssipenko
Copy link

@martinssipenko martinssipenko commented Sep 16, 2022 •
edited
Loading

Summary

Fixes faulty return type hint which leads to PHPStan reporting following error when I implement UserProfileServiceInterface.

Return type (array<int, mixed>|null) of method App\UserProfileService::lookup()
should be compatible with return type (Optimizely\UserProfile\userProfile) of
method Optimizely\UserProfile\UserProfileServiceInterface::lookup()

@martinssipenko martinssipenko requested a review from a team as a code owner September 16, 2022 15:12
@coveralls
Copy link

coveralls commented Oct 3, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 97.149% when pulling 5f7c64d on martinssipenko:patch-1 into fa9a3bf on optimizely:master.

@martinssipenko
Copy link
Author

@msohailhussain I believe CI checks are unrelated to my changes, could you please advise on how to move this foreward?

@mikechu-optimizely mikechu-optimizely mentioned this pull request Mar 27, 2023
Merged
@rafinutshaw-optimizely
Copy link
Contributor

Hi @martinssipenko ,
We've just published a patch version of the Optimizely PHP SDK to https://packagist.org/packages/optimizely/optimizely-sdk

Please update your PHP application, and you should be good to go.

@martinssipenko martinssipenko deleted the patch-1 branch March 29, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinssipenko martinssipenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinssipenko @coveralls @rafinutshaw-optimizely @msohailhussain
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy