Skip to content

SBI rework with QEMU SBI #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

SBI rework with QEMU SBI #765

merged 2 commits into from
Feb 7, 2025

Conversation

orangecms
Copy link
Contributor

No description provided.

@orangecms orangecms requested a review from rminnich February 6, 2025 15:17
@orangecms
Copy link
Contributor Author

see https://mastodon.social/@CyReVolt/113953915242150820 for a screenshot of running QEMU SBI

@orangecms orangecms enabled auto-merge (squash) February 6, 2025 16:07
@orangecms
Copy link
Contributor Author

orangecms commented Feb 6, 2025 •
edited
Loading

supersedes #703 and #584

@orangecms
Copy link
Contributor Author

will make #694 simpler

@orangecms orangecms mentioned this pull request Feb 6, 2025
Draft
@orangecms orangecms requested a review from luojia65 February 6, 2025 18:02
@orangecms
Copy link
Contributor Author

running barebox runs just fine as well:
https://mastodon.social/@CyReVolt/113958356804938812

@orangecms orangecms force-pushed the sbi-rework branch 2 times, most recently from 060cc33 to ecb9fa1 Compare February 6, 2025 22:00
@orangecms
arch/riscv/sbi: rework and simplify
2879c85 
- handle only non-delegated traps, drop unnecessary enum values
- shorten names
- clearly name assembly functions that save/restore state

Signed-off-by: Daniel Maslowski <info@orangecms.org>
@orangecms
emulation/qemu-riscv: implement Rust embedded traits and SBI
e22df78 
Signed-off-by: Daniel Maslowski <info@orangecms.org>
@orangecms orangecms mentioned this pull request Feb 7, 2025
Closed
luojia65
luojia65 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@luojia65 luojia65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can reuse uart16550 crate for QEMU virtio serial device.

@orangecms orangecms merged commit 5e87261 into oreboot:main Feb 7, 2025
4 checks passed
@orangecms orangecms deleted the sbi-rework branch February 7, 2025 01:31
@orangecms
Copy link
Contributor Author

LGTM, we can reuse uart16550 crate for QEMU virtio serial device.

Thanks! You mean https://docs.rs/uart_16550/latest/uart_16550/?
We currently use the ns16550 crate, which is essentially the same thing. Do you see an issue with it?

@luojia65
Copy link
Member

luojia65 commented Feb 7, 2025

It's my mistake, I thought that QEMUSerial is a special driver from register level, but it's actually a wrapper around Uart serial. That's fine to me now, thanks for pointing it out :) @orangecms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luojia65 luojia65 luojia65 approved these changes

@rminnich rminnich Awaiting requested review from rminnich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangecms @luojia65
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy