Start formatting tables with horizontal scroll and fixed-width font #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's no good to check note_content_section_text isn't displayed, as it's not found
|
@nevenz This works better than I expected. Do you think the ability to edit a table nicely is necessary or could we implement this display enhancement first? |
f538ac2 to
50b066e
Compare
|
@nevenz I added a very bare-bones edit screen. I tried reusing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from discussion on #74
In this approach the note's content is split into alternating table and text (i.e. non-table) content. The tables are then formatted with a fixed-width font, and horizontal scrolling is used to prevent text wrapping (wrapping makes tables basically unusable)
Before merging I'd at least need to address:
test breakageorg-javalibrary and storing result of the table/text parsing process in the database