refactor 9

fishercoder1534 · fishercoder1534 · commit 2f3f186aedb0 · 2019-03-23T08:55:33.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_9.java b/src/main/java/com/fishercoder/solutions/_9.java
@@ -17,28 +17,9 @@
  */
 public class _9 {
 
-    public static class Solution1 {
-        public boolean isPalindrome(int x) {
-            if (x == 0) {
-                return true;
-            }
-            if (x < 0) {
-                return false;
-            }
-            int rev = 0;
-            int tmp = x;
-            while (tmp != 0) {
-                rev *= 10;
-                rev += tmp % 10;
-                tmp /= 10;
-            }
-            return rev == x;
-        }
-    }
-
     /**credit: https://discuss.leetcode.com/topic/8090/9-line-accepted-java-code-without-the-need-of-handling-overflow
      * reversing only half and then compare if they're equal.*/
-    public static class Solution2 {
+    public static class Solution1 {
         public boolean isPalindrome(int x) {
             if (x < 0) {
                 return false;
diff --git a/src/test/java/com/fishercoder/_9Test.java b/src/test/java/com/fishercoder/_9Test.java
@@ -8,36 +8,30 @@
 
 public class _9Test {
     private static _9.Solution1 solution1;
-    private static _9.Solution2 solution2;
 
     @BeforeClass
     public static void setup() {
         solution1 = new _9.Solution1();
-        solution2 = new _9.Solution2();
     }
 
     @Test
     public void test1() {
         assertEquals(false, solution1.isPalindrome(2147483647));
-        assertEquals(false, solution2.isPalindrome(2147483647));
     }
 
     @Test
     public void test2() {
         assertEquals(true, solution1.isPalindrome(0));
-        assertEquals(true, solution2.isPalindrome(0));
     }
 
     @Test
     public void test3() {
         assertEquals(true, solution1.isPalindrome(1));
-        assertEquals(true, solution2.isPalindrome(1));
     }
 
     @Test
     public void test4() {
         assertEquals(false, solution1.isPalindrome(10));
-        assertEquals(false, solution2.isPalindrome(10));
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -8,36 +8,30 @@`
`8`	`8`
`9`	`9`	`public class _9Test {`
`10`	`10`	`private static _9.Solution1 solution1;`
`11`		`- private static _9.Solution2 solution2;`
`12`	`11`
`13`	`12`	`@BeforeClass`
`14`	`13`	`public static void setup() {`
`15`	`14`	`solution1 = new _9.Solution1();`
`16`		`- solution2 = new _9.Solution2();`
`17`	`15`	`}`
`18`	`16`
`19`	`17`	`@Test`
`20`	`18`	`public void test1() {`
`21`	`19`	`assertEquals(false, solution1.isPalindrome(2147483647));`
`22`		`- assertEquals(false, solution2.isPalindrome(2147483647));`
`23`	`20`	`}`
`24`	`21`
`25`	`22`	`@Test`
`26`	`23`	`public void test2() {`
`27`	`24`	`assertEquals(true, solution1.isPalindrome(0));`
`28`		`- assertEquals(true, solution2.isPalindrome(0));`
`29`	`25`	`}`
`30`	`26`
`31`	`27`	`@Test`
`32`	`28`	`public void test3() {`
`33`	`29`	`assertEquals(true, solution1.isPalindrome(1));`
`34`		`- assertEquals(true, solution2.isPalindrome(1));`
`35`	`30`	`}`
`36`	`31`
`37`	`32`	`@Test`
`38`	`33`	`public void test4() {`
`39`	`34`	`assertEquals(false, solution1.isPalindrome(10));`
`40`		`- assertEquals(false, solution2.isPalindrome(10));`
`41`	`35`	`}`
`42`	`36`
`43`	`37`	`}`