📦 serialization support + 🎚️ update OS & python version in test-matrix #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 98.12% 97.95% -0.17%
==========================================
Files 10 10
Lines 746 784 +38
==========================================
+ Hits 732 768 +36
- Misses 14 16 +2
Continue to review full report at Codecov.
|
🔥 add support for figure dict input + propagate _grid_str
|
Ready for review @jonasvdd |
🙃 add python3.10 (as string)
…ements 🌅 FigureResampler display improvements
jonasvdd
reviewed
Jul 11, 2022
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
| @@ -56,11 +56,33 @@ def __init__( | |||
| f = self._get_figure_class(go.FigureWidget)() | |||
| f._data_validator.set_uid = False | |||
|
|
|||
| if isinstance(figure, BaseFigure): # go.Figure or go.FigureWidget or AbstractFigureAggregator | |||
| # A base figure object, we first copy the layout and grid ref | |||
| if isinstance(figure, BaseFigure): | |||
There was a problem hiding this comment.
for some reason, the inherited docs also generate args and kwargs 🤷🏼
There was a problem hiding this comment.
aha, this is caused by the inheritence of the FigureWidget class.
jonasvdd
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #85
In shot this PR adds the following contributions;
=> serialize the plotly-resampler figure with its
hf_dataand other plotly-resampler properties, allowig pickling & (deep)copy!(the support for pickling allows to start processes that show a plotly-resampler figure via spawning)
This PR does;
FigureResampler(fig.to_dict())withfigago.Figure)=> this is in line with the vanilla plotly behavior (see
BaseFigureconstructor documentation)_grid_strin our composable constructorstest_fwr_time_based_data_s=> this allows starting a
multiprocessing.Processon Windows & Mac-OS (as these use spawning) https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods(note that this already worked on Unix as for such OS forking is used)
show_dashforFigureResampleron_ipython_display_show_dash_kwargstoFigureResamplerconstructorshow_dash_kwargs