Clean up a load of nolint comments #19599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c286c11 to
b40fb09
Compare
lunaris
approved these changes
May 21, 2025
| @@ -801,7 +801,7 @@ func TestResourceWithSecretSerializationNodejs(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| //nolint:paralleltest // mutates environment variables | |||
| //nolint:paralleltest // Calls t.Setenv in the test | |||
There was a problem hiding this comment.
The linter doesn't see this one?
There was a problem hiding this comment.
No seems it only sees things on the main path
tests/stack/stack_test.go
Outdated
| @@ -620,7 +620,8 @@ func stackFileFormatAsserters(t *testing.T, e *ptesting.Environment, projectName | |||
| return func() { doAssert(true) }, func() { doAssert(false) } | |||
| } | |||
|
|
|||
| func TestLocalStateGzip(t *testing.T) { //nolint:paralleltest | |||
| //nolint:paralleltest // Calls t.Setenv | |||
| func TestLocalStateGzip(t *testing.T) { | |||
There was a problem hiding this comment.
Similar questions about these ones
A combination of just removing nolint comments because the linter can now see t.Setenv calls, fixing the comments for some to correctly say why they are nolint, adding t.Setenv to make some tests more isolated, and adding t.Parallel to some tests that can actually support it.
b40fb09 to
9368529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing nolint comments because the linter can now see t.Setenv calls.
Prompted by #19593 (comment)