map_over_datasets: fix error message for wrong result type
#10016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I also found it helpful to have the result on a new line. before: TypeError: the result of calling func on the node at position 'ssp126' is not a Dataset or None or a tuple of such types: <xarray.DataArray 'selected_ar_order' (member: 1)> Size: 8B
array([2.])
Coordinates:
* member (member) <U8 32B 'r1i1p1f1'now: TypeError: the result of calling func on the node at position 'ssp126' is not a Dataset or None or a tuple of such types:
<xarray.DataArray 'selected_ar_order' (member: 1)> Size: 8B
array([2.])
Coordinates:
* member (member) <U8 32B 'r1i1p1f1' |
|
Thanks - I'll merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message did not indicate the name of the node which is fixed here.
It shows
'.'for the root node while the repr uses/which is maybe confusing. This comes from usingNodePath()- maybe this should be changed toNodePath("/")?xarray/xarray/core/treenode.py
Line 432 in c252152