Preserve label ordering for multi-variable GroupBy #10151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75f5c8b to
583a3d2
Compare
dcherian
commented
Mar 20, 2025
| @@ -3147,7 +3147,36 @@ def test_time_grouping_seasons_specified(): | |||
| assert_identical(actual, expected.reindex(season=labels)) | |||
|
|
|||
|
|
|||
| def test_groupby_multiple_bin_grouper_missing_groups(): | |||
| def test_multiple_grouper_unsorted_order() -> None: | |||
There was a problem hiding this comment.
The code is hard to review, but I would appreciate someone taking a look at this test.
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Mar 25, 2025
* upstream/main: Move chunks-related functions to a new file (pydata#10172) Preserve label ordering for multi-variable GroupBy (pydata#10151) Update DataArray.to_zarr to match Dataset.to_zarr. (pydata#10164) Fix numpy advanced indexing docs link (pydata#10160) Forbid datatree to zarr append dim (pydata#10156) Fix GitHub Actions badge in README (pydata#10155) Add dev whats-new (pydata#10152) Release 2025.03.0 (pydata#10143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst