From 01e75181ee904282e656ee01180c2d1d3e679239 Mon Sep 17 00:00:00 2001 From: TomNicholas Date: Thu, 24 Oct 2024 17:48:00 -0400 Subject: [PATCH 1/3] new blank whatsnew --- doc/whats-new.rst | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/doc/whats-new.rst b/doc/whats-new.rst index 9a451a836ad..18fae4e0151 100644 --- a/doc/whats-new.rst +++ b/doc/whats-new.rst @@ -14,6 +14,34 @@ What's New np.random.seed(123456) +.. _whats-new.2024.10.1: + +v.2024.10.1 (unreleased) +------------------------ + +New Features +~~~~~~~~~~~~ + + +Breaking changes +~~~~~~~~~~~~~~~~ + + +Deprecations +~~~~~~~~~~~~ + + +Bug fixes +~~~~~~~~~ + + +Documentation +~~~~~~~~~~~~~ + + +Internal Changes +~~~~~~~~~~~~~~~~ + .. _whats-new.2024.10.0: v2024.10.0 (Oct 24th, 2024) From 81b0df4a56952bb0a4822abbae3fe73690b39164 Mon Sep 17 00:00:00 2001 From: Tom Nicholas Date: Thu, 20 Mar 2025 10:33:05 -0400 Subject: [PATCH 2/3] forbid trying to append a DataTree to an existing zarr store --- xarray/core/datatree_io.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xarray/core/datatree_io.py b/xarray/core/datatree_io.py index 31f5a93dd5e..2a7dd4010f1 100644 --- a/xarray/core/datatree_io.py +++ b/xarray/core/datatree_io.py @@ -103,6 +103,11 @@ def _datatree_to_zarr( "specifying a root group for the tree has not been implemented" ) + if "append_dim" in kwargs: + raise NotImplementedError( + "specifying ``append_dim`` with ``DataTree.to_zarr`` has not been implemented" + ) + if encoding is None: encoding = {} From 0dba2f7496d1e6114b8da1d656ae016bbd4b7846 Mon Sep 17 00:00:00 2001 From: Tom Nicholas Date: Thu, 20 Mar 2025 10:37:40 -0400 Subject: [PATCH 3/3] release note --- doc/whats-new.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/whats-new.rst b/doc/whats-new.rst index 89bad8f99ad..088ffcc76dc 100644 --- a/doc/whats-new.rst +++ b/doc/whats-new.rst @@ -26,6 +26,9 @@ New Features Breaking changes ~~~~~~~~~~~~~~~~ +- Explicitly forbid appending a :py:class:`~xarray.DataTree` to zarr using :py:meth:`~xarray.DataTree.to_zarr` with ``append_dim``, because the expected behaviour is currently undefined. + (:issue:`9858`, :pull:`10156`) + By `Tom Nicholas `_. Deprecations ~~~~~~~~~~~~ pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy