(fix): allow upcasting of nans in as_shared_dtype
for extension arrays
#10292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve the underlying issue of reindexing with a fill value on an extension array (the test added is a reproducer), we special case nan values for type promotion because they are native pandas object that should be handled by the underlying extension arrays, which have a concept of nans in general (i.e., not specific to one kind of extension array, see: https://pandas.pydata.org/docs/reference/api/pandas.api.extensions.ExtensionArray.fillna.html)
Note this PR does not change the behavior otherwise - we still disallow categoricals, for example, from being collectively type-promoted. That could come in a separate PR, but would require further special casing i.e., for #10247
cc @ilia-kats
whats-new.rst
api.rst