Review request: Switching to Group in some pyparsing code #449
Replies: 2 comments 2 replies
-
|
I assume you are using the latest version of pyparsing (3.0.9)? |
Beta Was this translation helpful? Give feedback.
-
|
We have no specific fixed version, we use the latest in CI, and I think we somewhat encourage our users to do the same. Everything worked fine with |
Beta Was this translation helpful? Give feedback.
-
|
After cloning the repo, I added this to the bottom of parser.py: if __name__ == '__main__':
import pyparsing as pp
pp.autoname_elements()
QueryUnit.create_diagram("rdflib_query_unit.html")which generated this diagram: Maybe this will give some insights into your parser. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @ptmcg I will have a look at this |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, I'm not that knowledgeable with pyparsing and would like a second opinion on this PR which replaces some custom class with Group
If anyone could take a brief look I would appreciate it.
Beta Was this translation helpful? Give feedback.
All reactions