Skip to content

Commit 08c78ec

Browse files
committed
sax|etree: Simplify Expat version guard where simplifiable
Idea by Matěj Cepl
1 parent eebea7e commit 08c78ec

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

Lib/test/test_sax.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1215,10 +1215,10 @@ def test_expat_incremental_reset(self):
12151215

12161216
self.assertEqual(result.getvalue(), start + b"<doc>text</doc>")
12171217

1218+
@unittest.skipIf(pyexpat.version_info < (2, 6, 0),
1219+
f'Expat {pyexpat.version_info} does not '
1220+
'support reparse deferral')
12181221
def test_flush_reparse_deferral_enabled(self):
1219-
if pyexpat.version_info < (2, 6, 0):
1220-
self.skipTest(f'Expat {pyexpat.version_info} does not support reparse deferral')
1221-
12221222
result = BytesIO()
12231223
xmlgen = XMLGenerator(result)
12241224
parser = create_parser()

Lib/test/test_xml_etree.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1707,11 +1707,10 @@ def test_unknown_event(self):
17071707
with self.assertRaises(ValueError):
17081708
ET.XMLPullParser(events=('start', 'end', 'bogus'))
17091709

1710+
@unittest.skipIf(pyexpat.version_info < (2, 6, 0),
1711+
f'Expat {pyexpat.version_info} does not '
1712+
'support reparse deferral')
17101713
def test_flush_reparse_deferral_enabled(self):
1711-
if pyexpat.version_info < (2, 6, 0):
1712-
self.skipTest(f'Expat {pyexpat.version_info} does not '
1713-
'support reparse deferral')
1714-
17151714
parser = ET.XMLPullParser(events=('start', 'end'))
17161715

17171716
for chunk in ("<doc", ">"):

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy