gh-98724: Fix warnings on Py_SETREF() usage (#99781)

vstinner · web-flow · commit 5556d3e02ca8 · 2022-11-26T00:30:37.000+01:00
Cast argument to the expected type.
diff --git a/Modules/_curses_panel.c b/Modules/_curses_panel.c
@@ -424,7 +424,7 @@ _curses_panel_panel_replace_impl(PyCursesPanelObject *self,
         PyErr_SetString(state->PyCursesError, "replace_panel() returned ERR");
         return NULL;
     }
-    Py_SETREF(po->wo, Py_NewRef(win));
+    Py_SETREF(po->wo, (PyCursesWindowObject*)Py_NewRef(win));
     Py_RETURN_NONE;
 }
 
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -4775,7 +4775,7 @@ long_pow(PyObject *v, PyObject *w, PyObject *x)
          * because we're primarily trying to cut overhead for small powers.
          */
         assert(bi);  /* else there is no significant bit */
-        Py_SETREF(z, Py_NewRef(a));
+        Py_SETREF(z, (PyLongObject*)Py_NewRef(a));
         for (bit = 2; ; bit <<= 1) {
             if (bit > bi) { /* found the first bit */
                 assert((bi & bit) == 0);
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -9593,7 +9593,7 @@ super_init_impl(PyObject *self, PyTypeObject *type, PyObject *obj) {
             return -1;
         Py_INCREF(obj);
     }
-    Py_XSETREF(su->type, Py_NewRef(type));
+    Py_XSETREF(su->type, (PyTypeObject*)Py_NewRef(type));
     Py_XSETREF(su->obj, obj);
     Py_XSETREF(su->obj_type, obj_type);
     return 0;

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,7 @@ _curses_panel_panel_replace_impl(PyCursesPanelObject *self,`
`424`	`424`	`PyErr_SetString(state->PyCursesError, "replace_panel() returned ERR");`
`425`	`425`	`return NULL;`
`426`	`426`	`}`
`427`		`- Py_SETREF(po->wo, Py_NewRef(win));`
	`427`	`+ Py_SETREF(po->wo, (PyCursesWindowObject*)Py_NewRef(win));`
`428`	`428`	`Py_RETURN_NONE;`
`429`	`429`	`}`
`430`	`430`
Original file line number	Diff line number	Diff line change
`@@ -9593,7 +9593,7 @@ super_init_impl(PyObject self, PyTypeObject type, PyObject *obj) {`
`9593`	`9593`	`return -1;`
`9594`	`9594`	`Py_INCREF(obj);`
`9595`	`9595`	`}`
`9596`		`- Py_XSETREF(su->type, Py_NewRef(type));`
	`9596`	`+ Py_XSETREF(su->type, (PyTypeObject*)Py_NewRef(type));`
`9597`	`9597`	`Py_XSETREF(su->obj, obj);`
`9598`	`9598`	`Py_XSETREF(su->obj_type, obj_type);`
`9599`	`9599`	`return 0;`