[3.14] GH-137059: url2pathname(): fix support for drive letter in netloc (GH-137060) (#137144)

miss-islington · barneygale · web-flow · commit aeb55ebb0774 · 2025-07-28T22:43:15.000+03:00
Co-authored-by: Barney Gale &lt;barney.gale@gmail.com&gt;
diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
@@ -1590,6 +1590,10 @@ def test_url2pathname_resolve_host(self):
     def test_url2pathname_win(self):
         fn = urllib.request.url2pathname
         self.assertEqual(fn('/C:/'), 'C:\\')
+        self.assertEqual(fn('//C:'), 'C:')
+        self.assertEqual(fn('//C:/'), 'C:\\')
+        self.assertEqual(fn('//C:\\'), 'C:\\')
+        self.assertEqual(fn('//C:80/'), 'C:80\\')
         self.assertEqual(fn("///C|"), 'C:')
         self.assertEqual(fn("///C:"), 'C:')
         self.assertEqual(fn('///C:/'), 'C:\\')
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
@@ -1660,7 +1660,10 @@ def url2pathname(url, *, require_scheme=False, resolve_host=False):
     if scheme != 'file':
         raise URLError("URL is missing a 'file:' scheme")
     if os.name == 'nt':
-        if not _is_local_authority(authority, resolve_host):
+        if authority[1:2] == ':':
+            # e.g. file://c:/file.txt
+            url = authority + url
+        elif not _is_local_authority(authority, resolve_host):
             # e.g. file://server/share/file.txt
             url = '//' + authority + url
         elif url[:3] == '///':
diff --git a/Misc/NEWS.d/next/Library/2025-07-24-00-38-07.gh-issue-137059.fr64oW.rst b/Misc/NEWS.d/next/Library/2025-07-24-00-38-07.gh-issue-137059.fr64oW.rst
@@ -0,0 +1,3 @@
+Fix handling of file URLs with a Windows drive letter in the URL authority
+by :func:`urllib.request.url2pathname`. This fixes a regression in earlier
+pre-releases of Python 3.14.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Fix handling of file URLs with a Windows drive letter in the URL authority`
	`2`	+by :func:`urllib.request.url2pathname`. This fixes a regression in earlier
	`3`	`+pre-releases of Python 3.14.`