Skip to content

test_zoneinfo_property.py misses tests with all pickle protocols #136297

New issue
New issue
Closed
Closed
test_zoneinfo_property.py misses tests with all pickle protocols#136297
Assignees
sobolevn
Labels
testsTests in the Lib/test dir
@sobolevn

Description

@sobolevn
sobolevn
opened on Jul 4, 2025

cpython/Lib/test/test_zoneinfo/test_zoneinfo_property.py

Lines 145 to 162 in d1d5dce

@hypothesis.given(key=valid_keys())
@add_key_examples
def test_pickle_unpickle_cache(self, key):
zi = self.klass(key)
pkl_str = pickle.dumps(zi)
zi_rt = pickle.loads(pkl_str)
self.assertIs(zi, zi_rt)
@hypothesis.given(key=valid_keys())
@add_key_examples
def test_pickle_unpickle_no_cache(self, key):
zi = self.klass.no_cache(key)
pkl_str = pickle.dumps(zi)
zi_rt = pickle.loads(pkl_str)
self.assertIsNot(zi, zi_rt)
self.assertEqual(str(zi), str(zi_rt))

We should add all protocols to the test, since it might affect the property based testing.

Linked PRs

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dir

Projects

Date and time issues 🕰️

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy