alterando biblioteca de manipulação com o sistema e retirando try excepts desnecessarios

guilhermesrc · guilhermesrc · commit 964d587718e9 · 2023-11-13T20:49:01.000-03:00
diff --git a/.github/scripts/get_translated_strings_between_commits.py b/.github/scripts/get_translated_strings_between_commits.py
@@ -1,4 +1,4 @@
-import os
+import subprocess
 from pathlib import Path
 import re
 
@@ -8,29 +8,21 @@
 
 def run_os_command(command):
     try:
-        return os.popen(command).read()
-    except Exception as e:
-        print(f"Error executing OS command: {e}")
-        return ""
+        return subprocess.check_output(command, shell=True, text=True)
+    except subprocess.CalledProcessError as e:
+        print(f"Error executing command '{command}': {e}")
+        return None
 
 
 def get_translated_commit_strings(commit_hash):
-    try:
-        run_os_command(f"git switch --force {commit_hash} --detach")
-        pocount_of_commit = run_os_command(f"pocount {absolute_path}/*.po {absolute_path}/**/*.po")
-        all_translated_results = re.findall(pattern_translated_strings, pocount_of_commit, re.DOTALL)
-        total_of_translated_commit_strings = int(all_translated_results[-1])
-        return total_of_translated_commit_strings
-    except Exception as e:
-        print(f"Error getting translated strings count: {e}")
-        return 0
+    run_os_command(f"git switch --force {commit_hash} --detach")
+    pocount_of_commit = run_os_command(f"pocount {absolute_path}/*.po {absolute_path}/**/*.po")
+    all_translated_results = re.findall(pattern_translated_strings, pocount_of_commit, re.DOTALL)
+    total_of_translated_commit_strings = int(all_translated_results[-1])
+    return total_of_translated_commit_strings
 
 
 def get_difference_between_translated_commits_strings(commit_hash1, commit_hash2):
-    try:
-        commit_hash1_count = get_translated_commit_strings(commit_hash1)
-        commit_hash2_count = get_translated_commit_strings(commit_hash2)
-        return commit_hash1_count - commit_hash2_count
-    except Exception as e:
-        print(f"Error calculating the difference between translated strings counts: {e}")
-        return 0
+    commit_hash1_count = get_translated_commit_strings(commit_hash1)
+    commit_hash2_count = get_translated_commit_strings(commit_hash2)
+    return commit_hash1_count - commit_hash2_count
