Skip to content

Commit a69a331

Browse files
committed
small fixes to address bnavigator review
1 parent 03322ff commit a69a331

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

control/tests/iosys_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ def test_algebraic_loop(self, tsys):
427427
# Nonlinear system composed with LTI system (series) -- with states
428428
ios_t, ios_y = ios.input_output_response(
429429
nlios * lnios * nlios, T, U, X0)
430-
lti_t, lti_y, = ct.forced_response(linsys, T, U*U, X0)
430+
lti_t, lti_y = ct.forced_response(linsys, T, U*U, X0)
431431
np.testing.assert_array_almost_equal(ios_y, lti_y*lti_y, decimal=3)
432432

433433
# Nonlinear system in feeback loop with LTI system
@@ -483,7 +483,7 @@ def test_summer(self, tsys):
483483
U = [np.sin(T), np.cos(T)]
484484
X0 = 0
485485

486-
lin_t, lin_y, = ct.forced_response(linsys_parallel, T, U, X0)
486+
lin_t, lin_y = ct.forced_response(linsys_parallel, T, U, X0)
487487
ios_t, ios_y = ios.input_output_response(iosys_parallel, T, U, X0)
488488
np.testing.assert_allclose(ios_y, lin_y,atol=0.002,rtol=0.)
489489

control/tests/lti_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ def test_squeeze(self, fcn, nstate, nout, ninp, squeeze, shape):
180180
if fcn == ct.frd:
181181
sys = fcn(ct.rss(nstate, nout, ninp), omega)
182182
elif fcn == ct.tf and (nout > 1 or ninp > 1) and not slycot_check():
183-
# Conversion of MIMO systems to transfer functions require slycot
184-
return
183+
pytest.skip("Conversion of MIMO systems to transfer functions "
184+
"requires slycot.")
185185
else:
186186
sys = fcn(ct.rss(nstate, nout, ninp))
187187

control/tests/timeresp_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -724,8 +724,8 @@ def test_squeeze(self, fcn, nstate, nout, ninp, squeeze, shape):
724724

725725
# Define the system
726726
if fcn == ct.tf and (nout > 1 or ninp > 1) and not slycot_check():
727-
# Conversion of MIMO systems to transfer functions require slycot
728-
return
727+
pytest.skip("Conversion of MIMO systems to transfer functions "
728+
"requires slycot.")
729729
else:
730730
sys = fcn(ct.rss(nstate, nout, ninp, strictly_proper=True))
731731

@@ -753,7 +753,7 @@ def test_squeeze(self, fcn, nstate, nout, ninp, squeeze, shape):
753753
else:
754754
assert xvec.shape[1] == 8
755755

756-
# Test cases were we choose a subset of inputs and outputs
756+
# Test cases where we choose a subset of inputs and outputs
757757
_, yvec = ct.step_response(
758758
sys, tvec, input=ninp-1, output=nout-1, squeeze=squeeze)
759759
if squeeze is False:

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy