[IMP] use ujson instead of json (#24)

mpanarin · gatesn · commit cecdcae65207 · 2019-11-16T09:15:47.000Z
diff --git a/examples/langserver.py b/examples/langserver.py
@@ -1,4 +1,4 @@
-import json
+import ujson as json
 import logging
 
 from tornado import web, ioloop, websocket
diff --git a/examples/langserver_ext.py b/examples/langserver_ext.py
@@ -1,4 +1,4 @@
-import json
+import ujson as json
 import logging
 import subprocess
 import threading
diff --git a/pyls_jsonrpc/streams.py b/pyls_jsonrpc/streams.py
@@ -1,5 +1,5 @@
 # Copyright 2018 Palantir Technologies, Inc.
-import json
+import ujson as json
 import logging
 import threading
 
diff --git a/setup.py b/setup.py
@@ -34,6 +34,7 @@
     install_requires=[
         'future>=0.14.0',
         'futures; python_version<"3.2"',
+        'ujson<=1.35',
     ],
 
     # List additional groups of dependencies here (e.g. development
diff --git a/test/test_streams.py b/test/test_streams.py
@@ -78,15 +78,28 @@ def test_writer(wfile, writer):
         'params': {}
     })
     assert wfile.getvalue() == (
-        b'Content-Length: 49\r\n'
+        b'Content-Length: 44\r\n'
         b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
         b'\r\n'
-        b'{"id": "hello", "method": "method", "params": {}}'
+        b'{"id":"hello","method":"method","params":{}}'
     )
 
 
 def test_writer_bad_message(wfile, writer):
-    # A datetime isn't serializable, ensure the write method doesn't throw
+    # A datetime isn't serializable(or poorly serializable),
+    # ensure the write method doesn't throw
     import datetime
-    writer.write(datetime.datetime.now())
-    assert wfile.getvalue() == b''
+    writer.write(datetime.datetime(
+        year=2019,
+        month=1,
+        day=1,
+        hour=1,
+        minute=1,
+        second=1,
+    ))
+    assert wfile.getvalue() == (
+        b'Content-Length: 10\r\n'
+        b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
+        b'\r\n'
+        b'1546304461'
+    )

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import json`
	`1`	`+import ujson as json`
`2`	`2`	`import logging`
`3`	`3`
`4`	`4`	`from tornado import web, ioloop, websocket`