index setter was leaking memory

lostmsu · lostmsu · commit ac605fd3e3cc · 2025-04-10T21:39:47.000-07:00
diff --git a/src/runtime/Types/ClassBase.cs b/src/runtime/Types/ClassBase.cs
@@ -497,14 +497,8 @@ static int mp_ass_subscript_impl(BorrowedReference ob, BorrowedReference idx, Bo
             // Add value to argument list
             Runtime.PyTuple_SetItem(real.Borrow(), i, v);
 
-            cls.indexer.SetItem(ob, real.Borrow());
-
-            if (Exceptions.ErrorOccurred())
-            {
-                return -1;
-            }
-
-            return 0;
+            using var result = cls.indexer.SetItem(ob, real.Borrow());
+            return result.IsNull() ? -1 : 0;
         }
 
         static NewReference tp_call_impl(BorrowedReference ob, BorrowedReference args, BorrowedReference kw)
diff --git a/src/runtime/Types/Indexer.cs b/src/runtime/Types/Indexer.cs
@@ -50,9 +50,9 @@ internal NewReference GetItem(BorrowedReference inst, BorrowedReference args)
         }
 
 
-        internal void SetItem(BorrowedReference inst, BorrowedReference args)
+        internal NewReference SetItem(BorrowedReference inst, BorrowedReference args)
         {
-            SetterBinder.Invoke(inst, args, null);
+            return SetterBinder.Invoke(inst, args, null);
         }
 
         internal bool NeedsDefaultArgs(BorrowedReference args)

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,9 @@ internal NewReference GetItem(BorrowedReference inst, BorrowedReference args)`
`50`	`50`	`}`
`51`	`51`
`52`	`52`
`53`		`- internal void SetItem(BorrowedReference inst, BorrowedReference args)`
	`53`	`+ internal NewReference SetItem(BorrowedReference inst, BorrowedReference args)`
`54`	`54`	`{`
`55`		`- SetterBinder.Invoke(inst, args, null);`
	`55`	`+ return SetterBinder.Invoke(inst, args, null);`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`internal bool NeedsDefaultArgs(BorrowedReference args)`