Skip to content

Commit ce44877

Browse files
fduwjjpytorchmergebot
authored andcommitted
[c10d][PGNCCL] Make watchdog thread a class (#155831)
By extracting both monitor thread and watchdog thread into a separate class this will help us learn what dependencies we have for each thread and it will kind of simplify the consolidation work for each thread (consolidating from thread per PG instance to per PG class) Pull Request resolved: #155831 Approved by: https://github.com/d4l3k, https://github.com/kwen2501
1 parent c5d00e1 commit ce44877

File tree

3 files changed

+445
-374
lines changed

3 files changed

+445
-374
lines changed

test/cpp/c10d/ProcessGroupNCCLErrorsTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ class ProcessGroupNCCLTimedOutErrors : public ProcessGroupNCCLSimulateErrors {
164164
// so we have this hack to manually set the desync debug flag after PG
165165
// creation.
166166
void forceSetDesyncDebugFlag() {
167-
desyncDebug_ = true;
167+
watchdog_->setDesyncDebug(true);
168168
}
169169

170170
private:

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy