Skip to content

tighten pt2 FX graph invariants #157919

@zou3519

Description

@zou3519
  1. No dict proxies
  2. No dataclass proxies

The main motivation is that fx passes are really difficult to write when there are dict or dataclass operations in the graph. E.g. the dict lookup below

Image

For dicts, this means we would rewrite the triton_kernel_wrapper* HOPs to not use dicts, or shepherd them to use flat_apply HOPs.

For dataclass, we would need to fix invoke_quant somehow.

Thoughts @oulgen, @aakhundov, @davidberard98, @eellison?

cc @chauhang @penguinwu @ydwu4 @bdhirsh

Metadata

Metadata

Assignees

No one assigned

    Labels

    module: higher order operatorstorch.cond and similarmodule: pt2-dispatcherPT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op,oncall: pt2triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy