Skip to content

[BE][MPS] Prefer xfail to skip #134858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[BE][MPS] Prefer xfail to skip #134858

wants to merge 3 commits into from
+41 −37

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 30, 2024 •
edited
Loading

This essentially undoes large skips on everything but MacOS Sequoia to nn.modules made by #128393

Instead it uses existing xfail, but guards it on _macos15_or_newer boolean

Before the change if run on MacOS 14:

 % python3 ../test/test_modules.py -v -k Hardswish 2>&1|tail -n3
Ran 57 tests in 0.053s

OK (skipped=32)

After

% python3 ../test/test_modules.py -v -k Hardswish 2>&1|tail -n3
Ran 57 tests in 0.229s

OK (skipped=10, expected failures=2)

@malfet
[BE][MPS] Prefer xfail to skip
f8aeb1e 
This essentially undoes large skips on everything but MacOS sequioia to nn.modules made by #128393

Instead it uses existing `xfail`, but guards it on `_macos15_or_newer` boolean
@malfet malfet requested a review from mruberry as a code owner August 30, 2024 14:00
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134858

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 753b3a3 with merge base 8b68912 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested review from albanD and janeyx99 August 30, 2024 14:00
@malfet malfet added topic: not user facing topic category ciflow/mps Run MPS tests (subset of trunk) labels Aug 30, 2024
janeyx99
janeyx99 reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR assumes that the tests all pass on macos15 or newer, yes?
Failing CI is relevant.

@malfet
Copy link
Contributor Author

malfet commented Aug 30, 2024

@janeyx99 indeed they are, I haven't realized that skipMPSVersionIfLessThan crept into test_nn.py...

janeyx99
janeyx99 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitty comment

@malfet
Copy link
Contributor Author

malfet commented Aug 31, 2024

@pytorchbot merge -f "Lint and MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@hvaara hvaara mentioned this pull request Sep 10, 2024
Closed
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@malfet @Chao1Han
[BE][MPS] Prefer xfail to skip (pytorch#134858)
ed38f6f 
This essentially undoes large skips on everything but MacOS Sequoia to nn.modules made by pytorch#128393

Instead it uses existing `xfail`, but guards it on `_macos15_or_newer` boolean

Before the change if run on MacOS 14:
```
 % python3 ../test/test_modules.py -v -k Hardswish 2>&1|tail -n3
Ran 57 tests in 0.053s

OK (skipped=32)
```
After
```
% python3 ../test/test_modules.py -v -k Hardswish 2>&1|tail -n3
Ran 57 tests in 0.229s

OK (skipped=10, expected failures=2)
```

Pull Request resolved: pytorch#134858
Approved by: https://github.com/janeyx99
@github-actions github-actions bot deleted the malfet/mps-xfail-rather-than-skip branch October 3, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @pytorchmergebot @janeyx99
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy