[cp] dispatch flex_attention_backward to CP impl in TorchDispatchMode #152311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152311
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 1721481 with merge base ba51f48 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
fegin
requested changes
May 27, 2025
| self.comm_module_counts[par]["backward"] = defaultdict(int) | ||
| self.comm_module_counts[par][key][func_packet] += 1 | ||
| # TODO (xilunwu): this is a temporary hack to unblock the issue | ||
| # in tracking flex_attention_backward. Need to fix it later on. |
There was a problem hiding this comment.
Can we describe more about what is the issue?
There was a problem hiding this comment.
added description of the issue
There was a problem hiding this comment.
is it always a lambda or is dependent on what score_mod you pass in? But tbh I dont really know much about this code path
| device_mesh = mode._sharder._mesh | ||
| cp_block_mask = mode._sharder.get_cp_block_mask(mode._sharder._block_mask) | ||
|
|
||
| # TODO: save global KV in forward |
There was a problem hiding this comment.
Do we want to save global KVs? Would it cause OOM?
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
…ispatchMode" cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
fegin
approved these changes
Jun 2, 2025
superiwan
pushed a commit
to superiwan/pytorch
that referenced
this pull request
Jul 14, 2025
ghstack-source-id: ca0c15e Pull Request resolved: pytorch/pytorch#152311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k