-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Fixes for CPython int/float tests #155978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CPython int/float tests #155978
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155978
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 61ef011 with merge base 1c8844d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch/_dynamo/polyfills/sys.py
Outdated
@substitute_in_graph(sys.get_int_max_str_digits, can_constant_fold_through=True) | ||
def get_int_max_str_digits() -> int: | ||
return sys.get_int_max_str_digits() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@substitute_in_graph(sys.get_int_max_str_digits, can_constant_fold_through=True) | |
def get_int_max_str_digits() -> int: | |
return sys.get_int_max_str_digits() | |
if hasattr(sys, "get_int_max_str_digits"): | |
# sys.get_int_max_str_digits was added in 3.11.0, 3.10.7, and 3.9.14. | |
@substitute_in_graph(sys.get_int_max_str_digits, can_constant_fold_through=True) | |
def get_int_max_str_digits() -> int: | |
return sys.get_int_max_str_digits() | |
__all__ += ["get_int_max_str_digits"] |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
@pytorchbot rebase |
Current CI failure doesn't seem related but rebasing just in case. |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_11-cuda12_6-test / test Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames