Add transpose to torch/csrc/stable #158160
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158160
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit bdb90cd with merge base 900fba4 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
There was a problem hiding this comment.
Thanks for getting to this quickly!
One important part of this task (that does not need to be in this PR) is that we should add instructions in the suppress bc lint check to update the stable transpose function here if the API for at::transpose ever changes (otherwise it wouldn't actually be stable)
test/cpp_extensions/libtorch_agnostic_extension/libtorch_agnostic/csrc/kernel.cpp
Outdated
Show resolved
Hide resolved
[ghstack-poisoned]
[ghstack-poisoned]
There was a problem hiding this comment.
Thanks! LGTM in approach!
I have a q on how you chose ops.h (does it follow an existing ops.h?) I'm also thinking if we want to have ops.h import from like csrc/stable/transpose.h so people can include all the ops or optionally only include only the ops they use.
|
Ah good point, no I didn't follow any convention in choosing ops.h, where would I look to understand the convention here? I can move transpose to a separate transpose.h instead |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):