Some AMQP 0.9.1 headers, in particular x-death headers, cannot be set as

mkuratczyk · mkuratczyk · commit c5271ea6021e · 2025-04-25T15:46:45.000+02:00
application properties. Before this change, trying to shovel
dead-lettered messages from an AMQP 0.9.1 source to AMQP 1.0 destination
would fail with:
```
reason: {badarg,
            [{unicode,characters_to_binary,
                 [[{table,
                       [{&lt;&lt;"count"&gt;&gt;,long,1},
                        {&lt;&lt;"reason"&gt;&gt;,longstr,&lt;&lt;"maxlen"&gt;&gt;},
                        {&lt;&lt;"queue"&gt;&gt;,longstr,&lt;&lt;"tmp"&gt;&gt;},
                        {&lt;&lt;"time"&gt;&gt;,timestamp,1745575728},
                        {&lt;&lt;"exchange"&gt;&gt;,longstr,&lt;&lt;&gt;&gt;},
                        {&lt;&lt;"routing-keys"&gt;&gt;,array,
                         [{longstr,&lt;&lt;"tmp"&gt;&gt;}]}]}]],
                 [{file,"unicode.erl"},
                  {line,1219},
                  {error_info,#{module =&gt; erl_stdlib_errors}}]},
             {amqp10_client_types,utf8,1,
                 [{file,"amqp10_client_types.erl"},{line,99}]},
             {amqp10_msg,'-set_application_properties/2-fun-0-',3,
                 [{file,"amqp10_msg.erl"},{line,385}]},
             {maps,fold_1,4,[{file,"maps.erl"},{line,860}]},
             {amqp10_msg,set_application_properties,2,
                 [{file,"amqp10_msg.erl"},{line,384}]},
             {maps,fold_1,4,[{file,"maps.erl"},{line,860}]},
             {rabbit_amqp10_shovel,forward,4,
                 [{file,"rabbit_amqp10_shovel.erl"},{line,337}]},
             {rabbit_shovel_worker,handle_info,2,
                 [{file,"rabbit_shovel_worker.erl"},{line,104}]}]}
```
diff --git a/deps/rabbitmq_shovel/Makefile b/deps/rabbitmq_shovel/Makefile
@@ -23,7 +23,7 @@ dep_amqp10_client = git https://github.com/rabbitmq/rabbitmq-amqp1.0-client.git
 
 LOCAL_DEPS = crypto
 
-TEST_DEPS = rabbitmq_ct_helpers rabbitmq_ct_client_helpers rabbitmq_amqp1_0 meck
+TEST_DEPS = rabbitmq_ct_helpers rabbitmq_ct_client_helpers rabbitmq_amqp1_0 rabbitmq_amqp_client meck
 
 PLT_APPS += rabbitmq_cli
 
diff --git a/deps/rabbitmq_shovel/src/rabbit_amqp10_shovel.erl b/deps/rabbitmq_shovel/src/rabbit_amqp10_shovel.erl
@@ -445,6 +445,4 @@ bin_to_hex(Bin) ->
 is_amqp10_compat(T) ->
     is_binary(T) orelse
     is_number(T) orelse
-    %% TODO: not all lists are compatible
-    is_list(T) orelse
     is_boolean(T).
diff --git a/deps/rabbitmq_shovel/test/amqp10_dynamic_SUITE.erl b/deps/rabbitmq_shovel/test/amqp10_dynamic_SUITE.erl
@@ -27,7 +27,8 @@ groups() ->
           autodelete_amqp091_dest_on_confirm,
           autodelete_amqp091_dest_on_publish,
           simple_amqp10_dest,
-          simple_amqp10_src
+          simple_amqp10_src,
+          amqp091_to_amqp10_with_dead_lettering
         ]},
       {with_map_config, [], [
           simple,
@@ -96,6 +97,29 @@ simple_amqp10_dest(Config) ->
                                       <<"src-queue">>)
       end).
 
+amqp091_to_amqp10_with_dead_lettering(Config) ->
+    Dest = ?config(destq, Config),
+    Src = ?config(srcq, Config),
+    TmpQ = <<"tmp">>,
+    with_session(Config,
+      fun (Sess) ->
+              {ok, LinkPair} = rabbitmq_amqp_client:attach_management_link_pair_sync(Sess, <<"my link pair">>),
+              {ok, _} = rabbitmq_amqp_client:declare_queue(LinkPair, TmpQ,
+                                               #{arguments =>#{<<"x-max-length">> => {uint, 0},
+                                                               <<"x-dead-letter-exchange">> => {utf8, <<"">>},
+                                                               <<"x-dead-letter-routing-key">> => {utf8, Src}}}),
+              {ok, Sender} = amqp10_client:attach_sender_link(Sess,
+                                                              <<"sender-tmp">>,
+                                                              <<"/queues/", TmpQ/binary>>,
+                                                              unsettled,
+                                                              unsettled_state),
+              ok = await_amqp10_event(link, Sender, attached),
+              expect_empty(Sess, TmpQ),
+              test_amqp10_destination(Config, Src, Dest, Sess, <<"amqp091">>, <<"src-queue">>),
+              %% publish to tmp, it should be dead-lettered to src and then shovelled to dest
+              _ = publish_expect(Sess, TmpQ, Dest, <<"tag1">>, <<"hello">>)
+      end).
+
 test_amqp10_destination(Config, Src, Dest, Sess, Protocol, ProtocolSrc) ->
     MapConfig = ?config(map_config, Config),
     shovel_test_utils:set_param(Config, <<"test">>,
