Skip to content

When modifying a saved setting using the "Edit Config" in the "Ingress" settings menu, deleting the middle line of the saved rule will delete "Path" but delete the bottom line of "Target Service" and "Port". #11115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
parjom opened this issue May 24, 2024 · 4 comments
Open

When modifying a saved setting using the "Edit Config" in the "Ingress" settings menu, deleting the middle line of the saved rule will delete "Path" but delete the bottom line of "Target Service" and "Port". #11115

parjom opened this issue May 24, 2024 · 4 comments
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Milestone
v2.13.0

Comments

@parjom
Copy link

parjom commented May 24, 2024

Setup

  • Rancher version: v2.8.3 or latest
  • Rancher UI Extensions: none
  • Browser type & version: Chrome 125.0.6422.76

Describe the bug

When modifying a saved setting using the "Edit Config" in the "Ingress" settings menu, deleting the middle line of the saved rule will delete "Path" but delete the bottom line of "Target Service" and "Port".
Check out the video for details

movie

To Reproduce
Check out the video for details

Result
I fixed the bug and posted it on my github repository. Please refer to it.

master...parjom:dashboard:master

Expected Result

Screenshots

Additional context
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label May 24, 2024
@joesims22
Copy link

I was able to reproduce the issue on v2.8.4

  1. Create three services with different port numbers(for readability sake) in the default namespace on the local cluster.
  2. Create an ingress in the default namespace on the local cluster.
  3. While creating the ingress add a path (e.g. "/test-service-1") for each of the services previously created.
  4. Save the ingress
  5. Edit Config of the ingress and remove the middle path from the Rules
  6. Observe that the "Target Service" and "Port" columns of the bottom path have been deleted and the values from the deleted middle row are now present.

@torchiaf torchiaf changed the title When modifying a saved setting using the "Edit Config" in the "Ingress" settings menu, deleting the middle line of the saved rule will delete "Path" but delete the bottom line of "Target Service" and "Port".<bug title: summarize bug in one line> When modifying a saved setting using the "Edit Config" in the "Ingress" settings menu, deleting the middle line of the saved rule will delete "Path" but delete the bottom line of "Target Service" and "Port". May 24, 2024
@torchiaf
Copy link
Member

torchiaf commented May 24, 2024 •
edited
Loading

Thanks @parjom If you are confident of your fix, could you please submit a new PR ? We will take a look at it.

@parjom
Copy link
Author

parjom commented May 27, 2024 •
edited
Loading

Thanks @parjom If you are confident of your fix, could you please submit a new PR ? We will take a look at it.

I put up PR
#11125

@richard-cox richard-cox added this to the v2.9.0 milestone May 27, 2024
@richard-cox richard-cox mentioned this issue May 27, 2024
Closed
7 tasks
@richard-cox richard-cox modified the milestones: v2.9.0, v2.10.0 Jul 1, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@richard-cox richard-cox modified the milestones: v2.10.0, v2.11.0 Oct 16, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@richard-cox richard-cox mentioned this issue Feb 27, 2025
Merged
7 tasks
@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Mar 5, 2025
@nwmac nwmac modified the milestones: v2.11.0, v2.12.0 Mar 11, 2025
@richard-cox
Copy link
Member

See #11125 for a possible solution

@nwmac nwmac modified the milestones: v2.12.0, v2.13.0 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging a pull request may close this issue.

Fix: Fixing a problem where :key is not generated for v-for when modi… parjom/dashboard
5 participants
@nwmac @richard-cox @torchiaf @parjom @joesims22
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy