Skip to content

Decouple the Management of System-Upgrade-Controller from Fleet #13065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eva-vashkevich opened this issue Jan 10, 2025 · 5 comments · May be fixed by #14436
Open

Decouple the Management of System-Upgrade-Controller from Fleet #13065

eva-vashkevich opened this issue Jan 10, 2025 · 5 comments · May be fixed by #14436
Assignees
Labels
area/clusterprovisioningv2 kind/enhancement QA/manual-test Indicates issue requires manually testing RFD size/1 Size Estimate 1
Milestone

Comments

@eva-vashkevich
Copy link
Member

eva-vashkevich commented Jan 10, 2025

RFD: https://github.com/SUSE/rancher-architecture/pull/7
JIRA: SURE-9499
We need to update the description of the k3s-based-upgrader-uninstall-concurrency global setting to remove the reference to "imported clusters". This setting will now apply to both imported and node-driver clusters.

Updates on 5/20:

Additionally, A new setting needs to be added to the list:

  • Name: system-agent-upgrader-install-concurrency (default: 5)
  • Description: Defines the maximum number of clusters in which Rancher can concurrently install the resources required for upgrading system-agent.
@eva-vashkevich eva-vashkevich added this to the v2.11.0 milestone Jan 10, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 10, 2025
@richard-cox richard-cox added the RFC Originated or linked to an RFC label Jan 13, 2025
@gaktive gaktive added QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1 and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Jan 14, 2025
@gaktive
Copy link
Member

gaktive commented Feb 18, 2025

Related backend rancher/rancher#47737 now in 2.12.0 so pushing this out of 2.11.0.

@gaktive gaktive modified the milestones: v2.11.0, v2.12.0 Feb 18, 2025
@gaktive
Copy link
Member

gaktive commented Feb 18, 2025

@richard-cox if you have the RFC link, let me know since I couldn't easily find it.

@richard-cox richard-cox changed the title Update description of k3s-based-upgrader-uninstall-concurrency global setting Decouple the Management of System-Upgrade-Controller from Fleet Apr 4, 2025
@richard-cox richard-cox added RFD and removed RFC Originated or linked to an RFC labels Apr 4, 2025
@richard-cox
Copy link
Member

The description of the k3s-based-upgrader-uninstall-concurrency setting needs to be updated by removing the reference to "imported clusters" as this setting will now apply to both imported and node-driver clusters.

We should update to cover both types rather than remove one (to avoid confusion)

A new setting needs to be added to the list:

  • Name: system-agent-upgrader-install-concurrency (default: 5)
  • Description: Defines the maximum number of clusters in which Rancher can concurrently install the resources required for upgrading system-agent.

We should consider if this is something to show in the ui or not

@eva-vashkevich
Copy link
Member Author

Hi @richard-cox
'Defines the maximum number of clusters in which Rancher can concurrently uninstall the legacy rancher-k3s-upgrader or rancher-rke2-upgrader app from imported or node-driver K3s or RKE2 clusters.' Doesn't it sound a bit awkward? Maybe we should just change it to 'Defines the maximum number of clusters in which Rancher can concurrently uninstall the legacy rancher-k3s-upgrader or rancher-rke2-upgrader app from K3s or RKE2 clusters.' Because I don't think there is any other type of K3s or RKE2 cluster

@richard-cox
Copy link
Member

The description of the k3s-based-upgrader-uninstall-concurrency setting needs to be updated by removing the reference to "imported clusters" as this setting will now apply to both imported and node-driver clusters.

We should update to cover both types rather than remove one (to avoid confusion)

^

There is also custom clusters, however not sure how they align with this feature. Otherwise we could mention "all" types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterprovisioningv2 kind/enhancement QA/manual-test Indicates issue requires manually testing RFD size/1 Size Estimate 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy