Skip to content

Prevent unauthorized PR to be merged without CI check #13969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cnotv opened this issue Apr 2, 2025 · 0 comments
Open

Prevent unauthorized PR to be merged without CI check #13969

cnotv opened this issue Apr 2, 2025 · 0 comments
Labels
area/engineering Vue 3, linting, CI, release process kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.13.0

Comments

@cnotv
Copy link
Member

cnotv commented Apr 2, 2025 •
edited
Loading

CI BUG

Describe the bug
PRs can be inadvertently merged without any check if submitted by unauthorized users or if a new commit is submitted.
Example: #11650

NOTE: If merged, it will exclude the last commits!

To Reproduce
The external user creates a PR and is approved.
(Optional) a new commit is created after the first authorized CI check.

Result
PR can be merged without a new check, if new commits are added, they will be discarded.

Expected Result
Merge is prevented without a CI check as usual.

Screenshots

Additional context
@cnotv cnotv added this to the v2.12.0 milestone Apr 2, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Apr 2, 2025
@nwmac nwmac added area/engineering Vue 3, linting, CI, release process and removed area/ci labels May 1, 2025
@nwmac nwmac modified the milestones: v2.12.0, v2.13.0 May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/engineering Vue 3, linting, CI, release process kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.13.0
Development

No branches or pull requests
2 participants
@nwmac @cnotv
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy