Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected basic 16 terminal colors displayed on some apps #464

Closed
haxibami opened this issue Feb 26, 2024 · 10 comments
Closed

Unexpected basic 16 terminal colors displayed on some apps #464

haxibami opened this issue Feb 26, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@haxibami
Copy link

On other competing terminals (e.g. alacritty, foot), colors mapped to ESC[38;5;⟨n⟩m, n in {0..15} (= 0-15 in 8-bit, 256 colors) are the same as ESC[⟨n⟩m, n in {30..37, 90..97} (= basic 16 colors), but on rio this seems not to be the case. Below is an example.

image

16colors.sh:

#!/usr/bin/env bash

echo "\$TERM: $TERM"
echo "\$COLORTERM: $COLORTERM"

for i in {30..37} {90..97}; do echo -e "\e[${i}m ESC[${i}m \e[0m"; done

for i in {0..15}; do echo -e "\e[38;5;${i}m ESC[38;5;${i}m \e[0m"; done

This affects some terminal apps, such as bottom and neofetch. These apps (probably) get basic 16 colors (9, 10, 11, ... or LightRed, LightGreen, LightYellow, ...) from 0-15 in 8-bit 256 colors, resulting in different colors being displayed on rio.

image
@raphamorim raphamorim added the bug Something isn't working label Feb 28, 2024
@raphamorim
Copy link
Owner

Hey @haxibami thanks for the issue and sorry for late reply,

I can reproduce it on latest marking as a bug.

just to take note: which OS are you using and which rio version?

@haxibami
Copy link
Author

haxibami commented Feb 28, 2024 •
edited
Loading

OS: Linux (Arch Linux, official package)
Rio Version: 0.0.35

@LuarRaNa
Copy link

I am not sure if it is related but using nushell I get the following results compared to Alacritty.
image
image
The value for "green bold" in Rio is lighter than it is shown in Alacritty. The same for "red bold" and other ansi colors in bold. Even comparing "green" and "green bold" in Rio shows the difference.

OS: macOS Sonoma
Rio Version: 0.0.36

@LuarRaNa
Copy link

Digging a little deeper, I found that Alacritty and Wezterm have a setting related to bold drawn text using the bright color palette.
Alacritty:
draw_bold_text_with_bright_colors default false.
Wezterm:
bold_brightens_ansi_colors default true
At first Wezterm behaved similarly to Rio but by changing its option to false, it displays bold text correctly.

@nat-418
Copy link

nat-418 commented Mar 25, 2024

Same issue with Rio 0.0.34 on NixOS 23.11.

@cwegener
Copy link
Contributor

cwegener commented Apr 6, 2024

Is this related to the existing issue? #188

@raphamorim
Copy link
Owner

raphamorim commented Apr 24, 2024 •
edited
Loading

Yea, is connected partially with @cwegener , the thing is that rio (today) sets colors based on RGBA >255, to fix this specific issue is basically correct the default colors. Probably I will patch it for 0.1.0 which will take longer to release, but if anyone would like to pick up the changes and apply for the branch 0.0.x I can make a release with the fix.

@freijon
Copy link

freijon commented Jan 16, 2025

any updates for this? It's basically the main reason why I don't like using rio at the moment.

@raphamorim
Copy link
Owner

Oops i forgot about this issue,

Added to the next roadmap , will try to sort out to next or next-next release

@raphamorim raphamorim moved this to In Progress in Rio terminal 0.2.x Jan 17, 2025
@raphamorim raphamorim mentioned this issue Jan 29, 2025
Merged
@raphamorim
Copy link
Owner

Fixed in #926

@github-project-automation github-project-automation bot moved this from In Progress to Done in Rio terminal 0.2.x Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Rio terminal 0.2.x
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@freijon @cwegener @raphamorim @haxibami @LuarRaNa @nat-418
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy