pieeprom-2025-07-17: 2711: Also require the early-watchdog property (latest) #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latest) * arm_loader: Also require the early-watchdog property The change correcting the implementation of dtoverlay_is_enabled had the unintended consequence of causing the firmware to enable the watchdog even though the user had not explicitly requested it. This is harmless on Linux because the watchdog driver takes over and disarms it, but on other operating systems this can lead to a reboot. Avoid this problem by also requiring the presence of a new property, "early-watchdog". See: raspberrypi/firmware#1980 * helpers/config_loader: Add bootvar0 eeprom config that can be used in config.txt section expressions This allows an eeprom config setting (e.g. BOOTARG0=0x10) to be set on a board which config.txt can use as a conditional expression (e.g. [bootarg0&0x10]). * arm_loader: Fix boot-watchdog stop on Pi4 Fix a problem where the boot_watchdog heartbeat timer was not stopped correctly which could cause it to clash with the kernel watchdog driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change correcting the implementation of dtoverlay_is_enabled had the unintended consequence of causing the firmware to enable the watchdog even though the user had not explicitly requested it. This is harmless on Linux because the watchdog driver takes over and disarms it, but on other operating systems this can lead to a reboot. Avoid this problem by also requiring the presence of a new property, "early-watchdog".
See: Raspberry Pi 4b ends up in a reboot loop since commit #3885768 running Zephyr firmware#1980
This allows an eeprom config setting (e.g. BOOTARG0=0x10) to be set on a board which config.txt can use as a conditional expression (e.g. [bootarg0&0x10]).
Fix a problem where the boot_watchdog heartbeat timer was not stopped correctly which could cause it to clash with the kernel watchdog driver.