chore: use node's spawn instead of tinyexec dep (#1227)

efstathiosntonas · web-flow · commit fccdf6742ed4 · 2025-05-28T05:05:43.000+02:00
diff --git a/lib/plugin/git/Git.js b/lib/plugin/git/Git.js
@@ -1,5 +1,5 @@
 import { EOL } from 'node:os';
-import { x } from 'tinyexec';
+import { spawn } from 'node:child_process';
 import matcher from 'wildcard-match';
 import { format, e, fixArgs, once, castArray } from '../../util.js';
 import GitBase from '../GitBase.js';
@@ -11,11 +11,13 @@ const options = { write: false };
 
 const docs = 'https://git.io/release-it-git';
 
-const isGitRepo = () =>
-  x('git', ['rev-parse', '--git-dir'], { throwOnError: true }).then(
-    () => true,
-    () => false
-  );
+async function isGitRepo() {
+  return await new Promise((resolve) => {
+    const proc = spawn('git', ['rev-parse', '--git-dir']);
+    proc.on('close', code => resolve(code === 0));
+    proc.on('error', () => resolve(false));
+  });
+}
 
 class Git extends GitBase {
   constructor(...args) {
diff --git a/lib/shell.js b/lib/shell.js
@@ -1,6 +1,5 @@
 import util from 'node:util';
-import childProcess from 'node:child_process';
-import { x } from 'tinyexec';
+import childProcess, { spawn } from 'node:child_process';
 import { format } from './util.js';
 
 const debug = util.debug('release-it:shell');
@@ -68,21 +67,52 @@ class Shell {
     });
   }
 
-  async execWithArguments(command, options, { isExternal }) {
+  async execWithArguments(command, options = {}, { isExternal } = {}) {
     const [program, ...programArgs] = command;
 
     try {
-      const { stdout: out, stderr } = await x(program, programArgs, { throwOnError: true });
-      const stdout = out === '""' ? '' : out;
-      this.log.verbose(stdout, { isExternal });
-      debug({ command, options, stdout, stderr });
-      return Promise.resolve((stdout || stderr).trim());
+      return await new Promise((resolve, reject) => {
+        const proc = spawn(program, programArgs, {
+          // we want to capture all output from the process so the extra 2 pipe
+          stdio: ['inherit', 'pipe', 'pipe'],
+          ...options,
+        });
+
+        let stdout = '';
+        let stderr = '';
+
+        proc.stdout.on('data', data => {
+          stdout += data.toString();
+        });
+
+        proc.stderr.on('data', data => {
+          stderr += data.toString();
+        });
+
+        proc.on('close', (code) => {
+          stdout = stdout === '""' ? '' : stdout;
+          this.log.verbose(stdout, { isExternal });
+          debug({ command, options, stdout, stderr });
+
+          if (code === 0) {
+            resolve((stdout || stderr).trim());
+          } else {
+            if (stdout) {
+              this.log.log(`\n${stdout}`);
+            }
+            debug({ code, command, options, stdout, stderr });
+            reject(new Error(stderr || stdout || `Process exited with code ${code}`));
+          }
+        });
+
+        proc.on('error', err => {
+          debug(err);
+          reject(new Error(err.message));
+        });
+      });
     } catch (err) {
-      if (err.output.stdout) {
-        this.log.log(`\n${err.output.stdout}`);
-      }
       debug(err);
-      return Promise.reject(new Error(err.output.stderr || err.output.stdout || err.message));
+      return Promise.reject(err);
     }
   }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -97,7 +97,6 @@
     "os-name": "6.0.0",
     "proxy-agent": "6.5.0",
     "semver": "7.7.1",
-    "tinyexec": "1.0.1",
     "tinyglobby": "0.2.13",
     "undici": "6.21.2",
     "url-join": "5.0.0",
