-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@rematch/select type error. #945
Comments
Reselect changed his internal typings in a minor version, and that probably caused our @rematch/select typings to fail. |
I'm willing to fix it. But I'm new here, perhaps need your help. |
No problems. Feel free to ask here for any questions you encountered. |
To be honest the rematch doesn't 100% compatible with |
With old They rewrote his codebase to TS and now they're only compatible with TypeScript 4.2+. We could ship a fix for this on a major version of @rematch/select, In this way our users could use:
And other users could use:
What do you think? I think is worth it to invest in this, we keep a better development line than RTK. @NoahStepheno You can read CONTRIBUTING.md how to clone, setup, and work with Rematch codebase. Feel free to ask anything on Discord or here if you feel stuck. |
That was great. Yes - It's worth investing in this. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe the bug
I use
@rematch/select
in my project of typescript. const selection = store.select(/* ignore */). The type of selection is any.Reproduce Link
https://codesandbox.io/s/magical-goldwasser-reg5l?file=/src/AppWithHooks.tsx
To Reproduce
useSelector
to get a stateExpected behavior
show the right type
Screenshots
Desktop
Additional context
I realized that the problem is on 'reselect'. After upgrading to 4.1.1,
@rematch/select
get a type error. But in the monorepo packages. It will always install 4.0.0 'reselect', and do not get this error.The text was updated successfully, but these errors were encountered: