Fix outstanding requests exception message

jr01 · richardszalay · commit 4536be6b1582 · 2022-07-12T21:50:59.000+10:00
Fixes a concurrency issue where between lines `outstandingRequests > 0` and `throw new InvalidOperationException` another thread would increment/decrement `outstandingRequests`. See https://stackoverflow.com/a/24893231 Fixes `oustanding` to `outstanding` in the exception message.
diff --git a/RichardSzalay.MockHttp.Shared/MockHttpMessageHandler.cs b/RichardSzalay.MockHttp.Shared/MockHttpMessageHandler.cs
@@ -267,8 +267,9 @@ protected override void Dispose(bool disposing)
         /// </summary>
         public void VerifyNoOutstandingRequest()
         {
-            if (outstandingRequests > 0)
-                throw new InvalidOperationException("There are " + outstandingRequests + " oustanding requests. Call Flush() to complete them");
+            var requests = Interlocked.CompareExchange(ref outstandingRequests, 0, 0);
+            if (requests > 0)
+                throw new InvalidOperationException("There are " + requests + " outstanding requests. Call Flush() to complete them");
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -267,8 +267,9 @@ protected override void Dispose(bool disposing)`
`267`	`267`	`/// </summary>`
`268`	`268`	`public void VerifyNoOutstandingRequest()`
`269`	`269`	`{`
`270`		`- if (outstandingRequests > 0)`
`271`		`- throw new InvalidOperationException("There are " + outstandingRequests + " oustanding requests. Call Flush() to complete them");`
	`270`	`+ var requests = Interlocked.CompareExchange(ref outstandingRequests, 0, 0);`
	`271`	`+ if (requests > 0)`
	`272`	`+ throw new InvalidOperationException("There are " + requests + " outstanding requests. Call Flush() to complete them");`
`272`	`273`	`}`
`273`	`274`
`274`	`275`	`/// <summary>`