Skip to content

SecureADODB: Existence of IDbConnection_CreateCommand appears counterintuitive #7

@pchemguy

Description

@pchemguy

What is the idea behind the IDbConnection_CreateCommand interface method?
IDbCommandFactory takes an IDbConnection interface and returns an IDbCommand interface with the logical place for initialization of the object behind it (as initiated via the .Execute method) being the IDbCommandBase_CreateCommand interface. However, IDbCommandBase_CreateCommand in turn calls IDbConnection_CreateCommand interface, which merely duplicates the Guards present in IDbCommandBase_CreateCommand and then sets basic command properties passed from IDbCommandBase_CreateCommand. It appears that this way unnecessary coupling and a loop IDbConnection->IDbCommand->IDbConnection are generated.
I would remove the IDbConnection_CreateCommand interface, placing all of the necessary code in IDbCommandBase_CreateCommand. I can submit a pull request for this issue.

SecureADODB_CreateCommand

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy