fix: fix view already has a parent bug

rigor789 · rigor789 · commit e2525440836b · 2018-01-10T13:28:08.000Z
fixes nativescript-vue#59, closes nativescript-vue#78
diff --git a/package.json b/package.json
@@ -69,7 +69,7 @@
     "rollup-plugin-resolve-aliases": "^0.2.0",
     "rollup-watch": "^3.2.2",
     "semver": "^5.4.1",
-    "tns-core-modules": "^3.3.0",
+    "tns-core-modules": "^3.4.0",
     "util-inspect": "^0.1.8",
     "vue": "^2.5.13"
   },
@@ -83,8 +83,7 @@
       "!**/node_modules/**"
     ],
     "moduleDirectories": [
-      "node_modules",
-      "<rootDir>/node_modules/tns-core-modules"
+      "node_modules"
     ],
     "modulePathIgnorePatterns": [
       "<rootDir>/samples"
diff --git a/platform/nativescript/framework.js b/platform/nativescript/framework.js
@@ -3,7 +3,10 @@
 global.process = global.process || {}
 global.process.env = global.process.env || {}
 
+import { VUE_VM_REF } from './runtime'
 import inspect from 'util-inspect'
+import { topmost } from 'ui/frame'
+import application from 'application'
 import Vue from './runtime/index'
 import ModalPlugin from './plugins/modal-plugin'
 import NavigatorPlugin from './plugins/navigator-plugin'
@@ -30,4 +33,23 @@ console.keys = function(object) {
   console.log(Object.keys(object))
 }
 
+// this fixes the issue of resuming the application
+// however this might not be the desired functionality
+// Todo: figure out if there is a better way to fix application resume.
+application.on(application.exitEvent, () => {
+  const frame = topmost()
+  if (frame) {
+    console.log(frame)
+    frame.eachChildView(child => {
+      console.log('found child')
+      const vm = child[VUE_VM_REF]
+
+      if (vm) {
+        vm.$destroy()
+      }
+      frame._removeView(child)
+    })
+  }
+})
+
 export default Vue
diff --git a/platform/nativescript/plugins/navigator-plugin.js b/platform/nativescript/plugins/navigator-plugin.js
@@ -21,11 +21,13 @@ export default {
         const navigate = frame ? frame.navigate : start
 
         if (isPage(component)) {
-          return navigate({
-            create() {
-              return component
-            }
-          })
+          return navigate(
+            Object.assign(options, {
+              create() {
+                return component
+              }
+            })
+          )
         }
 
         const placeholder = Vue.$document.createComment('placeholder')
diff --git a/platform/nativescript/runtime/index.js b/platform/nativescript/runtime/index.js
@@ -53,6 +53,8 @@ const mount = function(el, hydrating) {
           page.content = self.$el.nativeView
         }
 
+        page[VUE_VM_REF] = self
+
         return page
       }
     })

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ const mount = function(el, hydrating) {`
`53`	`53`	`page.content = self.$el.nativeView`
`54`	`54`	`}`
`55`	`55`
	`56`	`+ page[VUE_VM_REF] = self`
	`57`	`+`
`56`	`58`	`return page`
`57`	`59`	`}`
`58`	`60`	`})`