Skip to content

#[target_feature] is allowed on default implementations #108646

@LeSeulArtichaut

Description

@LeSeulArtichaut

The compiler currently allows safe default method implementations to be marked with #[target_feature]:

trait Foo {
    #[target_feature(enable = "avx2")] // no error
    fn foo() {}
}

which I don't think is allowed in RFC 2396. For reference, #[target_feature] is not allowed on trait implementations:

struct Bar;

impl Foo for Bar {
    #[target_feature(enable = "avx2")] // error: cannot be applied to safe trait method
    fn foo() {}
}

From my limited testing, this doesn't seem to be unsound however, as the compiler seems to consider all implementations of Foo::foo as having #[target_feature(enable = "avx2")].

cc #69098
@rustbot label T-lang T-compiler C-bug F-target_feature_11

Metadata

Metadata

Labels

A-target-featureArea: Enabling/disabling target features like AVX, Neon, etc.C-bugCategory: This is a bug.F-target_feature_11target feature 1.1 RFCT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language teamrequires-nightlyThis issue requires a nightly compiler in some way.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy