fix(FreeBSD): upgrade to mysql57-server #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current default version for FreeBSD is MySQL 5.7, also python 2.x is deprecated and should be removed any time soon. FreeBSD uses the `mysql_install_db` which generates a temporary root password upon the first start. To the best of my understanding I haven't seen any code in the formula that handles this method. So I added a FreeBSD-scpecific block for initialization. While here, create `/var/log/mysql` without which the server won't start if it doesn't exist.
|
Best reviewed: commit by commit
Optimal code review plan
|
daks
approved these changes
Aug 21, 2020
|
It's almost 1AM, and I just realized I botched it. I'm closing it for now and will update with a new version tomorrow morning. |
|
I'm reopening the PR. Sorry, I thought I had seen a mistake on my end, but after a few more tests locally, the only mistake was trying to review my code at 1 AM. Again, really sorry for the going back and forth on this one. I'll try to be more careful next time. |
|
Merged, thanks @GeJ. I adjusted the commit message so that |
|
🎉 This PR is included in version 0.54.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
19 tasks
saltstack-formulas-travis
pushed a commit
that referenced
this pull request
Aug 27, 2020
## [0.54.2](v0.54.1...v0.54.2) (2020-08-27) ### Bug Fixes * **indent:** properly indent file.directory block ([7791268](7791268)), closes [#250](#250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Current default version for FreeBSD is MySQL 5.7, also python 2.x is
deprecated and should be removed any time soon.
FreeBSD uses the
mysql_install_dbwhich generates a temporary rootpassword upon the first start. To the best of my understanding I haven't
seen any code in the formula that handles this method. So I added
a FreeBSD-scpecific block for initialization. While here, create
/var/log/mysqlwithout which the server won't start if it doesn'texist.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context