Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Include all files necessary for testing #486

Open
2 tasks
hseg opened this issue Jun 2, 2024 · 2 comments
Open
2 tasks

Packaging: Include all files necessary for testing #486

hseg opened this issue Jun 2, 2024 · 2 comments

Comments

@hseg
Copy link

hseg commented Jun 2, 2024

Describe the bug
Attempting to package 2.0.0b7, I run into the problem that tests/test_entrypoint.py::test_gbk needs tests/resources/gbk_test.bib, which is not included in the tarball. I'm working around it by skipping that particular test, but the policy seems inconsistent -- either releases aren't meant to include tests (in which case the presence of the tests directory is weird) or they should include the resources necessary to run them (in which case gbk_test.bib's absence is weird)

Reproducing

Version: 2.0.0.b7

Code:

wget https://files.pythonhosted.org/packages/source/b/bibtexparser/bibtexparser-2.0.0b7.tar.gz
tar xvf bibtexparser-2.0.0b7.tar.gz
cd bibtexparser-2.0.0b7/
python -m pytest
....
======================================== short test summary info =========================================
FAILED tests/test_entrypoint.py::test_gbk - FileNotFoundError: [Errno 2] No such file or directory: 'tests/resources/gbk_test.bib'
====================================== 1 failed, 47 passed in 0.79s ======================================

Workaround
Invoking pytest instead as

python -m pytest -k 'not (test_entrypoint.py and test_gbk)'

which skips the broken test.

Remaining Questions (Optional)
Please tick all that apply:

  • I would be willing to contribute a PR to fix this issue.
  • This issue is a blocker, I'd be grateful for an early fix.
@hseg
Copy link
Author

hseg commented Jun 2, 2024

... I just found out the package has been adopted into the official repos, and so will not be packaging it. I hope the issue is still valuable to you, but won't be able to offer much help checking solutions. Sorry for the noise.

@MiWeiss
Copy link
Collaborator

MiWeiss commented Jun 11, 2024

thanks a lot. i'll have a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy