fix(har): omit content when False is passed (microsoft#959)

mxschmitt · web-flow · commit 6ecdf0ecddb7 · 2021-10-18T18:40:10.000+02:00
diff --git a/playwright/_impl/_browser.py b/playwright/_impl/_browser.py
@@ -210,7 +210,7 @@ async def normalize_context_params(is_sync: bool, params: Dict) -> None:
     if "recordHarPath" in params:
         params["recordHar"] = {"path": str(params["recordHarPath"])}
         if "recordHarOmitContent" in params:
-            params["recordHar"]["omitContent"] = True
+            params["recordHar"]["omitContent"] = params["recordHarOmitContent"]
             del params["recordHarOmitContent"]
         del params["recordHarPath"]
     if "recordVideoDir" in params:
diff --git a/tests/async/test_har.py b/tests/async/test_har.py
@@ -40,11 +40,24 @@ async def test_should_omit_content(browser, server, tmpdir):
         data = json.load(f)
         assert "log" in data
         log = data["log"]
-
         content1 = log["entries"][0]["response"]["content"]
         assert "text" not in content1
 
 
+async def test_should_not_omit_content(browser, server, tmpdir):
+    path = os.path.join(tmpdir, "log.har")
+    context = await browser.new_context(
+        record_har_path=path, record_har_omit_content=False
+    )
+    page = await context.new_page()
+    await page.goto(server.PREFIX + "/har.html")
+    await context.close()
+    with open(path) as f:
+        data = json.load(f)
+        content1 = data["log"]["entries"][0]["response"]["content"]
+        assert "text" in content1
+
+
 async def test_should_include_content(browser, server, tmpdir):
     path = os.path.join(tmpdir, "log.har")
     context = await browser.new_context(record_har_path=path)
