Final fix - all review comments

smtryingcode · smtryingcode · commit c2331d4fa852 · 2016-05-24T17:57:38.000+05:30
diff --git a/app/directives/distribution-graph/distribution-graph.directive.js b/app/directives/distribution-graph/distribution-graph.directive.js
@@ -271,7 +271,7 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
       })
       
       function isInArray(value, array) {
-        return array.indexOf(value) > -1;
+        return array.indexOf(value) > -1
       }
          
       svg.selectAll('line.xaxis')
diff --git a/app/directives/history-graph/history-graph.directive.js b/app/directives/history-graph/history-graph.directive.js
@@ -319,9 +319,5 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
       })
       return colors[0] && colors[0].color || 'black'
     }
-    
-    function isInArray(value, array) {
-      return array.indexOf(value) > -1;
-    }
   }
 })()
diff --git a/app/topcoder.constants.js b/app/topcoder.constants.js
@@ -44,8 +44,5 @@ angular.module('CONSTANTS', []).constant('CONSTANTS', {
   'REGISTERED'             : 'REGISTERED',
   'SUBMISSION_TYPE_CONTEST': 'Contest Submission',
   'STATUS_ACTIVE'          : 'Active',
-  'STATUS_COMPLETED_WITHOUT_WIN' : 'Completed Without Win',
-  'CHALLENGE_DETAIL_URL'   :  'https://www.topcoder-dev.com/challenge-details/',
-  'SRM_DETAIL_URL': 'https://community.topcoder-dev.com/stat?c=round_overview&rd=',
-  'MARATHON_DETAIL_URL': 'https://community.topcoder-dev.com/longcontest/stats/?module=ViewOverview&rd='
+  'STATUS_COMPLETED_WITHOUT_WIN' : 'Completed Without Win'
 })
diff --git a/package.json b/package.json
@@ -9,8 +9,7 @@
   },
   "devDependencies": {
     "angular-mocks": "^1.4.9",
-    "appirio-tech-webpack-config": "^0.3.5",
-    "babel-plugin-add-module-exports": "^0.2.1",
+    "appirio-tech-webpack-config": "^0.3.0",
     "babel-polyfill": "^6.7.2",
     "bardjs": "^0.1.8",
     "bower": "^1.6.8",
@@ -55,8 +54,7 @@
     "angularjs-toaster": "^1.0.0",
     "appirio-styles": "0.x.x",
     "appirio-tech-ng-iso-constants": "^1.0.6",
-    "appirio-tech-ng-ui-components": "^2.2.4",
-    "appirio-tech-react-components": "^0.0.12",
+    "appirio-tech-ng-ui-components": "^2.1.2",
     "auth0-angular": "^4.1.0",
     "auth0-js": "^6.8.0",
     "d3": "^3.5.14",
@@ -71,7 +69,6 @@
     "restangular": "^1.5.2",
     "tc-angular-ellipsis": "^0.1.6",
     "topcoder-app-r": "^1.0.0",
-    "webpack-hot-middleware": "^2.10.0",
     "xml2js": "^0.4.16",
     "zepto": "^1.0.1"
   }

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js`
`271`	`271`	`})`
`272`	`272`
`273`	`273`	`function isInArray(value, array) {`
`274`		`- return array.indexOf(value) > -1;`
	`274`	`+ return array.indexOf(value) > -1`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`svg.selectAll('line.xaxis')`
Original file line number	Diff line number	Diff line change
`@@ -319,9 +319,5 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js`
`319`	`319`	`})`
`320`	`320`	`return colors[0] && colors[0].color \|\| 'black'`
`321`	`321`	`}`
`322`		`-`
`323`		`- function isInArray(value, array) {`
`324`		`- return array.indexOf(value) > -1;`
`325`		`- }`
`326`	`322`	`}`
`327`	`323`	`})()`